Migrations as replicas refactor #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 28, 2024
Dany9966
force-pushed
the
migrations-as-replicas
branch
5 times, most recently
from
8012f7b to
8e5aeab
Compare
Dany9966
force-pushed
the
migrations-as-replicas
branch
4 times, most recently
from
b5947dd to
09283ab
Compare
Dany9966
force-pushed
the
migrations-as-replicas
branch
4 times, most recently
from
14af745 to
0a59754
Compare
Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
Adds the 'scenario' field to the `Replica` DB model and afferent
DB API functions for creating/filtering Replicas based on it.
The `scenario` can be one of:
* `replica` (the auto-default for all newly-created replicas)
* `live_migration` (special case for replicas-as-migrations)
Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
Update the conductor layer for separate handling of Live Migrations and deployments. Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
This patch makes sure that reservations only get deleted when a Transfer action is being deleted.
Fixes an edge-case where if a reservation cannot be found for an existing replica, and the minion pool set to it is also in an invalid state, a new reservation would be created but never saved to DB because of the minion pool error. This patch makes sure that the minion pool validation is done before the reservation checks when creating replica executions.
Raises proper exception when user attempts to re-execute or re-deploy an already fulfilled migration action.
Updates some conductor server unit tests
Refactors include mostly renames of Replica into Transfer, and Migration into Deployment. They also include some DB column refactoring (removing unnecessary ones).
Dany9966
force-pushed
the
migrations-as-replicas
branch
from
d70c4f4 to
3bad643
Compare
Dany9966
force-pushed
the
migrations-as-replicas
branch
3 times, most recently
from
d27636b to
41b9db9
Compare
Dany9966
force-pushed
the
migrations-as-replicas
branch
from
41b9db9 to
cf0c72c
Compare
Dany9966
force-pushed
the
migrations-as-replicas
branch
from
cf0c72c to
ee49009
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds all the core changes regarding the removal of the normal migration operation and replacing that with the replica workflow. This will give users full control of when to deploy the migration on the destination platform. Similar to replica deployments, this adds migration deployments (which still are one-time).
Meaningful changes that this PR adds:
scenariofield to the Replica model, which saves whether the transfer scenario is either a one-time migration, or a DR replica;deploymentsAPI paths, views, operations & policies;migrationsAPI paths;